Author Topic: Tags with spaces = fail  (Read 4079 times)

Offline Palamedes

  • Newbie
  • *
  • Posts: 36
  • Karma: +5/-0
    • View Profile
    • RandomStringOfWords
Tags with spaces = fail
« on: March 15, 2012, 08:01:09 PM »
Create a product and give it a tag "test tag".  Now visit that products page and click the "test tag" tag, the search results return nothing because space gets turned into %20 in the URL which doesn't get url decoded back for the query..

I imagine other special characters would also fail.  Tags should be stripped of all special characters except only those legal as a tag in a url .

Again this is something I could have fixed for you if there was a git repo..  :)
~Pal

Offline abolabo

  • core-developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 1788
  • Karma: +251/-11
  • web for all, all for web!
    • View Profile
    • AbanteCart
Re: Tags with spaces = fail
« Reply #1 on: March 16, 2012, 12:04:09 PM »
Create a product and give it a tag "test tag".  Now visit that products page and click the "test tag" tag, the search results return nothing because space gets turned into %20 in the URL which doesn't get url decoded back for the query..

I imagine other special characters would also fail.  Tags should be stripped of all special characters except only those legal as a tag in a url .

Again this is something I could have fixed for you if there was a git repo..  :)

Yes, was a bug.
Thanks.
“No one is useless in this world who lightens the burdens of another.”
― Charles Dickens

 

Powered by SMFPacks Social Login Mod