AbanteCart Community

AbanteCart Development => Extensions and Add-Ons => General Extensions => Topic started by: natdroid on January 10, 2019, 08:37:45 AM

Title: extensions fail php 7.3
Post by: natdroid on January 10, 2019, 08:37:45 AM
hi. i have six extensions stop working with AbanteCart php 7.3

config.xml
Code: [Select]
<item id="go_category">
      <type>multiselectbox</type>
          <variants>
      <data_source>
      <model_rt>catalog/category</model_rt>
      <method>getCategories</method>
      </data_source>
      <fields>
      <field>category_id</field>
      <field>name</field>
      </fields>
      </variants>
      </item>


call the mother abantecart function https://github.com/abantecart/abantecart-src/blob/master/public_html/admin/model/catalog/category.php#L221


but php 7.3 fatal error

Code: [Select]
Too few arguments to function ModelCatalogCategory::getCategories(), 0 passed in /admin/controller/pages/extension/extensions.php on line 433
 and at least 1 expected in <b>/admin/model/catalog/category.php</b> on line <b>221</b>


https://github.com/abantecart/abantecart-src/blob/master/public_html/admin/controller/pages/extension/extensions.php#L433


ASPAP client want to kill me . ****** help how to fix

Title: Re: extensions fail php 7.3
Post by: natdroid on January 10, 2019, 08:39:17 AM
i have many extensions same bug. Anyone help?
Title: Re: extensions fail php 7.3
Post by: abolabo on January 10, 2019, 09:57:42 AM
check this commit
https://github.com/abantecart/abantecart-src/commit/ae01eb4fd33d11aac618b3573066ba39367db65c
and let us know