AbanteCart Community

AbanteCart Development => Extensions and Add-Ons => Shipping Modules => Topic started by: CalSci on May 02, 2019, 06:35:09 AM

Title: USPS Girth Calculation
Post by: CalSci on May 02, 2019, 06:35:09 AM
In the file:
cart slash extensions slash default_usps slash storefront slash model slash extension slash default_usps.php

The following line is incorrect:

         // Calculate girth based on usps calculation
         $xml .= '      <Girth>' . (round(((float)$this->config->get('default_usps_length') + (float)$this->config->get('default_usps_width') * 2 + (float)$this->config->get('default_usps_height') * 2), 1)) . '</Girth>';

Girth is 2*width+2*height. USPS does use length+girth often, but that is not the same thing. Also that formula only works if length is longer than width and height, otherwise it needs to sort the longest side out of the formula.
Title: Re: USPS Girth Calculation
Post by: Basara on May 02, 2019, 06:48:12 AM
Hello.

Are you refer to this line ?
https://github.com/abantecart/abantecart-src/blob/master/public_html/extensions/default_usps/storefront/model/extension/default_usps.php#L199
Title: Re: USPS Girth Calculation
Post by: Basara on May 02, 2019, 06:52:47 AM
Girth is 2*width+2*height. USPS does use length+girth often, but that is not the same thing. Also that formula only works if length is longer than width and height, otherwise it needs to sort the longest side out of the formula.

Do you have any link to USPS manuals to verify that USPS calculate in your approach?
Title: Re: USPS Girth Calculation
Post by: Basara on May 02, 2019, 07:15:54 AM
Hi.
Here is what I found
https://pe.usps.com/text/qsg300/q201e.htm
Quote
Except for USPS Retail Ground and Parcel Select, no mailpiece may measure more than 108 inches in length and girth combined.
Title: Re: USPS Girth Calculation
Post by: CalSci on May 03, 2019, 12:27:15 AM
Yes, that is correct, USPS has limitations on length+girth. Girth = 2*width+2*height, assuming that length is the longest side. Girth+length = length+2*width+2*height. Girth itself does not include length in it.