Author Topic: default wt based for 1.3.4 Issue  (Read 3095 times)

Offline Nuno Neff

  • Full Member
  • ***
  • Posts: 194
  • Karma: +25/-7
    • View Profile
default wt based for 1.3.4 Issue
« on: January 27, 2024, 11:09:06 AM »
I have a client that tried to add the product to the Shopping Cart and it doesn't Estimate Shipping & Taxes, so i went to error log and theres something wrong with default wt based for 1.3.4 using php 8 +

existing default code set cost = '' instead of 0

php 8 does not allow string to be summed with integer

so the fix should be cost = 0;

line 55 in the code should be 0


Offline Basara

  • Administrator
  • Hero Member
  • *****
  • Posts: 5855
  • Karma: +275/-2
    • View Profile
Re: default wt based for 1.3.4 Issue
« Reply #1 on: January 29, 2024, 04:57:10 AM »
Hello.
What is your complete PHP version and what is "default code set cost"?

Offline abolabo

  • core-developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2052
  • Karma: +320/-13
  • web for all, all for web!
    • View Profile
    • AbanteCart
Re: default wt based for 1.3.4 Issue
« Reply #2 on: January 29, 2024, 05:01:01 AM »
please give us full test of error. What file with line 89?
“No one is useless in this world who lightens the burdens of another.”
― Charles Dickens

Offline Nuno Neff

  • Full Member
  • ***
  • Posts: 194
  • Karma: +25/-7
    • View Profile
Re: default wt based for 1.3.4 Issue
« Reply #3 on: January 29, 2024, 09:57:42 AM »
The file with line 89 is "default_weight/storefront/model/extension/default_weight.php"

My PHP Version 8.1.27

Offline yonghan79

  • Jr. Member
  • **
  • Posts: 58
  • Karma: +17/-0
    • View Profile
Re: default wt based for 1.3.4 Issue
« Reply #4 on: January 29, 2024, 10:49:01 AM »
Hi core devs,

The error is triggered when we set product fixed shipping along with the default weight shipping.

I tested with PHP 8.1.27.


Offline Basara

  • Administrator
  • Hero Member
  • *****
  • Posts: 5855
  • Karma: +275/-2
    • View Profile
Re: default wt based for 1.3.4 Issue
« Reply #5 on: January 30, 2024, 02:22:25 AM »
Thank you for the report.
Follow bug resolution on AbanteCart GitHub bug tracker https://github.com/abantecart/abantecart-src/issues/1674

Offline Basara

  • Administrator
  • Hero Member
  • *****
  • Posts: 5855
  • Karma: +275/-2
    • View Profile
Re: default wt based for 1.3.4 Issue
« Reply #6 on: January 31, 2024, 05:25:18 AM »
Thank you for the report.
Follow bug resolution on the AbanteCart GitHub bug tracker https://github.com/abantecart/abantecart-src/issues/1674
The issue is resolved. Check the commit in github.

Offline Nuno Neff

  • Full Member
  • ***
  • Posts: 194
  • Karma: +25/-7
    • View Profile
Re: default wt based for 1.3.4 Issue
« Reply #7 on: January 31, 2024, 11:03:41 AM »
Nice, I'm looking forward to upgrading to the new version ;)

Offline llegrand

  • Hero Member
  • *****
  • Posts: 1805
  • Karma: +525/-7
    • View Profile
Re: default wt based for 1.3.4 Issue
« Reply #8 on: February 08, 2024, 11:22:32 AM »
FYI ,  an easy way to get the file and how to install it for 1.3.4 is on our Patch files link
https://why2central.net/patch/abantecart-v1-3-4-default-weight-path-file/

Regards,
The WHY2 support team

Offline Nuno Neff

  • Full Member
  • ***
  • Posts: 194
  • Karma: +25/-7
    • View Profile
Re: default wt based for 1.3.4 Issue
« Reply #9 on: February 08, 2024, 05:02:21 PM »
Its not working, I have a attached a screenshot of what i get after aplying the patch file

« Last Edit: February 08, 2024, 05:14:42 PM by Nuno Neff »

Offline llegrand

  • Hero Member
  • *****
  • Posts: 1805
  • Karma: +525/-7
    • View Profile
Re: default wt based for 1.3.4 Issue
« Reply #10 on: February 09, 2024, 10:54:51 AM »
Update  to Nuno report of "not working" :   somewhere along the line the file he used was corrupted,  It is unknown at what stage.

We have corrected the issue for him on his site.   And just in case  we have replaced the patch file in our site.

All seems to be working correctly now.

the WHY2 support team

Offline Nuno Neff

  • Full Member
  • ***
  • Posts: 194
  • Karma: +25/-7
    • View Profile
Re: default wt based for 1.3.4 Issue
« Reply #11 on: February 09, 2024, 11:23:06 AM »
Confirmed ;) its working!

 

Powered by SMFPacks Social Login Mod