AbanteCart Community

Shopping Cart Operations => Support => General Support => Topic started by: Nuno Neff on January 27, 2024, 11:09:06 AM

Title: default wt based for 1.3.4 Issue
Post by: Nuno Neff on January 27, 2024, 11:09:06 AM

I have a client that tried to add the product to the Shopping Cart and it doesn't Estimate Shipping & Taxes, so i went to error log and theres something wrong with default wt based for 1.3.4 using php 8 +

existing default code set cost = '' instead of 0

php 8 does not allow string to be summed with integer

so the fix should be cost = 0;

line 55 in the code should be 0

Title: Re: default wt based for 1.3.4 Issue
Post by: Basara on January 29, 2024, 04:57:10 AM

Hello.
What is your complete PHP version and what is "default code set cost"?

Title: Re: default wt based for 1.3.4 Issue
Post by: abolabo on January 29, 2024, 05:01:01 AM

please give us full test of error. What file with line 89?

Title: Re: default wt based for 1.3.4 Issue
Post by: Nuno Neff on January 29, 2024, 09:57:42 AM

The file with line 89 is "default_weight/storefront/model/extension/default_weight.php"

My PHP Version 8.1.27

Title: Re: default wt based for 1.3.4 Issue
Post by: yonghan79 on January 29, 2024, 10:49:01 AM

Hi core devs,

The error is triggered when we set product fixed shipping along with the default weight shipping.

I tested with PHP 8.1.27.

Title: Re: default wt based for 1.3.4 Issue
Post by: Basara on January 30, 2024, 02:22:25 AM

Thank you for the report.
Follow bug resolution on AbanteCart GitHub bug tracker https://github.com/abantecart/abantecart-src/issues/1674

Title: Re: default wt based for 1.3.4 Issue
Post by: Basara on January 31, 2024, 05:25:18 AM

Quote from: Basara on January 30, 2024, 02:22:25 AM

Thank you for the report.
Follow bug resolution on the AbanteCart GitHub bug tracker https://github.com/abantecart/abantecart-src/issues/1674

The issue is resolved. Check the commit in github.

Title: Re: default wt based for 1.3.4 Issue
Post by: Nuno Neff on January 31, 2024, 11:03:41 AM

Nice, I'm looking forward to upgrading to the new version ;)

Title: Re: default wt based for 1.3.4 Issue
Post by: llegrand on February 08, 2024, 11:22:32 AM

FYI ,  an easy way to get the file and how to install it for 1.3.4 is on our Patch files link
https://why2central.net/patch/abantecart-v1-3-4-default-weight-path-file/ (https://why2central.net/patch/abantecart-v1-3-4-default-weight-path-file/)

Regards,
The WHY2 support team

Title: Re: default wt based for 1.3.4 Issue
Post by: Nuno Neff on February 08, 2024, 05:02:21 PM

Its not working, I have a attached a screenshot of what i get after aplying the patch file

Title: Re: default wt based for 1.3.4 Issue
Post by: llegrand on February 09, 2024, 10:54:51 AM

Update  to Nuno report of "not working" :   somewhere along the line the file he used was corrupted,  It is unknown at what stage.

We have corrected the issue for him on his site.   And just in case  we have replaced the patch file in our site.

All seems to be working correctly now.

the WHY2 support team

Title: Re: default wt based for 1.3.4 Issue
Post by: Nuno Neff on February 09, 2024, 11:23:06 AM

Confirmed ;) its working!