default wt based for 1.3.4 Issue

[Nuno Neff]

I have a client that tried to add the product to the Shopping Cart and it doesn't Estimate Shipping & Taxes, so i went to error log and theres something wrong with default wt based for 1.3.4 using php 8 +

existing default code set cost = '' instead of 0

php 8 does not allow string to be summed with integer

so the fix should be cost = 0;

line 55 in the code should be 0

[Basara]

Hello.
What is your complete PHP version and what is "default code set cost"?

[abolabo]

please give us full test of error. What file with line 89?

[Nuno Neff]

The file with line 89 is "default_weight/storefront/model/extension/default_weight.php"

My PHP Version 8.1.27

[yonghan79]

Hi core devs,

The error is triggered when we set product fixed shipping along with the default weight shipping.

I tested with PHP 8.1.27.

[Basara]

Thank you for the report.
Follow bug resolution on AbanteCart GitHub bug tracker https://github.com/abantecart/abantecart-src/issues/1674

[Basara]

Thank you for the report.
Follow bug resolution on the AbanteCart GitHub bug tracker https://github.com/abantecart/abantecart-src/issues/1674

The issue is resolved. Check the commit in github.

[Nuno Neff]

Nice, I'm looking forward to upgrading to the new version

[llegrand]

FYI ,  an easy way to get the file and how to install it for 1.3.4 is on our Patch files link
https://why2central.net/patch/abantecart-v1-3-4-default-weight-path-file/

Regards,
The WHY2 support team

[Nuno Neff]

Its not working, I have a attached a screenshot of what i get after aplying the patch file

[llegrand]

Update  to Nuno report of "not working" :   somewhere along the line the file he used was corrupted,  It is unknown at what stage.

We have corrected the issue for him on his site.   And just in case  we have replaced the patch file in our site.

All seems to be working correctly now.

the WHY2 support team

[Nuno Neff]

Confirmed its working!