"Free shipping" indicator does not always appear even if "Free shipping" flag on

[timlight10]

If a product has a "fixed shipping price" even when the "free shipping" flag is set, the "Free Shipping" icon does not appear on the storefront. Although the cart will offer free shipping correctly to the customer, it is not properly advertised.

For example, this product: https://dedicatedpresentation.com/collegiate/sharp-np-p547ul-5400-lumen-wuxga-laser-lcd-projector has the free shipping flag enabled, but does not have a fixed shipping price entered.

But this product does have a fixed shipping price entered, but its "free shipping" flag is also set. https://dedicatedpresentation.com/elite-screens-180-inch-yard-master-pro-2-series-portable-16x9-front--and-rear-projection-screen?key=13961

Notice though that for the first product it does have the red truck icon, but the second product does not have the red truck. But, since both products have free shipping, they should both have the red truck icon.

The use case is that for the second product, I would like to promote the free shipping until which time I revoke the free shipping offer and return to paid shipping. Therefore, the free shipping should be advertised when the flag is enabled, regardless of whether or not the other fields have values.

In both situations though, the customer is not charged for shipping, which is correct.

I filed this as a bug, because the free shipping indicator does not appear in all situations when shipping is free. The developer closed the bug report and responded:

please check this line
https://github.com/abantecart/abantecart-src/blob/master/public_html/extensions/novator/storefront/view/novator/template/pages/product/product.tpl#L293 and review product details in admin

Sure enough,

Code Select Expand

if($product_info['free_shipping'] && $product_info['shipping_price'] <= 0) { ?>
They pointed the bug out, but did not commit a fix. The correct fix would be to change

Code Select Expand

&& to

Code Select Expand

|| so that either situation will activate the free shipping label.

How is this not a bug?