Author Topic: PayPal Express seems to need guest checkout enabled to work  (Read 8578 times)

Offline llegrand

  • Hero Member
  • *****
  • Posts: 1798
  • Karma: +520/-7
    • View Profile
On Abantecart 1.2.6  I can get PayPal Express to show up on checkout ONLY if guest checkout is enabled.
If only allowing registered accounts,  no PayPal Express.

Is this a requirement for the extension?  Or some fix that needs to be accomplished?

Thanks
Lee

Offline Basara

  • Administrator
  • Hero Member
  • *****
  • Posts: 5787
  • Karma: +274/-2
    • View Profile
Re: PayPal Express seems to need guest checkout enabled to work
« Reply #1 on: May 05, 2016, 01:30:50 AM »
Hello.

Did you mean PayPal express button on shopping cart page or you did not see it in the payments methods list during checkout?

Offline llegrand

  • Hero Member
  • *****
  • Posts: 1798
  • Karma: +520/-7
    • View Profile
Re: PayPal Express seems to need guest checkout enabled to work
« Reply #2 on: May 05, 2016, 10:40:44 AM »
Express button will showed up in cart page if guest checkout is turned on.   Same thing in payment choices during checkout.

Please look at core/default_pp_express, hook the cart part.  that's how we finally found why we couldn't get it to work.

 line 97

« Last Edit: May 05, 2016, 10:56:58 AM by llegrand »

Offline abolabo

  • core-developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2048
  • Karma: +319/-13
  • web for all, all for web!
    • View Profile
    • AbanteCart
Re: PayPal Express seems to need guest checkout enabled to work
« Reply #3 on: May 06, 2016, 02:43:05 PM »
Express button will showed up in cart page if guest checkout is turned on.   Same thing in payment choices during checkout.

Please look at core/default_pp_express, hook the cart part.  that's how we finally found why we couldn't get it to work.

 line 97

hi.
please try to replace
Code: [Select]
|| !$that->config->get('config_guest_checkout')) {with this
Code: [Select]
|| (!$that->config->get('config_guest_checkout') && !$that->customer->isLogged())) {and let me know
“No one is useless in this world who lightens the burdens of another.”
― Charles Dickens

Offline llegrand

  • Hero Member
  • *****
  • Posts: 1798
  • Karma: +520/-7
    • View Profile
Re: PayPal Express seems to need guest checkout enabled to work
« Reply #4 on: May 08, 2016, 11:25:03 PM »
Sorry to report that the code change when applied in version 1.2.6  did not fix the issues

Guest checkout still needs to be enabled. 



Offline abolabo

  • core-developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2048
  • Karma: +319/-13
  • web for all, all for web!
    • View Profile
    • AbanteCart
Re: PayPal Express seems to need guest checkout enabled to work
« Reply #5 on: May 11, 2016, 04:35:05 PM »
Sorry to report that the code change when applied in version 1.2.6  did not fix the issues

Guest checkout still needs to be enabled.

are you sure that you changed code correctly? :o
it works correctly for me.
please replace whole file extensions/default_pp_express/core/default_pp_express.php (see attachment)

“No one is useless in this world who lightens the burdens of another.”
― Charles Dickens

Offline llegrand

  • Hero Member
  • *****
  • Posts: 1798
  • Karma: +520/-7
    • View Profile
Re: PayPal Express seems to need guest checkout enabled to work
« Reply #6 on: May 12, 2016, 10:12:51 AM »
Swapping out the file does work on 126.  Guest checkout still needs to be ON for the buttons to show on the checkout page ,   but I think that is okay.  Admin just needs to decide if they want guests or not,  then the payment buttons show up correctly.

I do suggest that this should be stated in the docs you need to add the info that Guest Checkout set to OFF will not show the PayPal Express on Checkout Page .

Thanks for working on this.

Lee





Offline webdevmerc

  • Full Member
  • ***
  • Posts: 172
  • Karma: +32/-1
    • View Profile
Re: PayPal Express seems to need guest checkout enabled to work
« Reply #7 on: May 12, 2016, 10:32:00 AM »
So when customers use Paypal Express, has anyone been able to see the Abantecart shopping cart also in the Paypal payment?

I have never been able to get that part to work even though I have read that the cart should pass over to Paypal.  Works in Paypal Standard though for me...

Offline Basara

  • Administrator
  • Hero Member
  • *****
  • Posts: 5787
  • Karma: +274/-2
    • View Profile
Re: PayPal Express seems to need guest checkout enabled to work
« Reply #8 on: May 13, 2016, 03:59:48 AM »
Hi, Lee

Finally I am able to replicate missed PayPal buttons when Guest Checkout OFF. Sorry I missed logged in/out case. Too busy. ::)

So if Guest checkout Disabled - these buttons will show but only for the Logged In Customers. If your customer is Not logged in and Guest Checkout Disabled - it should mean you not allow to checkout for Guests and thay's why there are nothing to checkout with PayPal Express

 

Powered by SMFPacks Social Login Mod